feat(module): ModuleBuilder::set_name() and ModuleBuilder::set_version() #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16813098701Details
💛 - Coveralls |
Xenira
requested changes
Jul 20, 2025
Member
Xenira
left a comment
Xenira
left a comment
There was a problem hiding this comment.
Thank you. Just some minor nitpicks
kakserpom
force-pushed
the
builder_override_name_and_version
branch
from
33ea193 to
3c2552e
Compare
Xenira
added a commit
to kakserpom/ext-php-rs
that referenced
this pull request
Aug 7, 2025
Xenira
added a commit
to kakserpom/ext-php-rs
that referenced
this pull request
Aug 7, 2025
Xenira
force-pushed
the
builder_override_name_and_version
branch
from
2c2114e to
84f93b3
Compare
Xenira
approved these changes
Aug 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It comes in handy to be able to change your extension name.